New mylist file flag: corrupted [DONE]

old granted and denied feature requests

Moderator: AniDB

PetriW
AniDB Staff
Posts: 1522
Joined: Sat May 24, 2003 2:34 pm

New mylist file flag: corrupted [DONE]

Post by PetriW »

Many want to add their files to the mylist, however they don't want to add it if it's corrupted, so they create a new entry, leading to Skywalka growing more insane each day.
How about if the user could add the file to the mylist but mark it corrupted? If a file is marked corrupted it's no longer added to toward total users who have the file but *ding ding* the user has it in his mylist.

This along with the file add sanity check suggested might be something quite nice. Plus it might encourage people to not add bogus files.

Notice, this would be a new fields so you can still add it as on hdd but corrupted.
PetriW
AniDB Staff
Posts: 1522
Joined: Sat May 24, 2003 2:34 pm

Post by PetriW »

And as the creator of AOM, if possible also add some means to add the ed2k of the corrupted file to that specific mylist entry. This way AOM can still autorename it etc once it's been associated with the file entry through the mylist. ;)

User gets to enter his ed2k, Skywalka gets to keep his sanity. (If there ever was one!)
wahaha
AniDB Staff
Posts: 1497
Joined: Sun Nov 17, 2002 3:33 pm

Post by wahaha »

I second the 2nd post ^^, but IMO it'd be nice to even have the full set of hashes for the corrupted file and also have this hash associated with the file (globally, instead of only the single mylist-entry).

A big question for the usability of this feature is whether there's any hash-like function that can help in determining two "similar" files... :?
Rar
AniDB Staff
Posts: 1471
Joined: Fri Mar 12, 2004 2:41 pm
Location: UK
Contact:

Post by Rar »

Me too, basically what I was trying to say in the other post, but PetriW put it better. :)

Rar
Skywalka
Posts: 889
Joined: Tue Sep 16, 2003 7:57 pm

Post by Skywalka »

*pouts*

Neat idea though

*keeps on pouting*
PetriW
AniDB Staff
Posts: 1522
Joined: Sat May 24, 2003 2:34 pm

Post by PetriW »

wahaha wrote:I second the 2nd post ^^, but IMO it'd be nice to even have the full set of hashes for the corrupted file and also have this hash associated with the file (globally, instead of only the single mylist-entry).
Problem with this is you get soooo many more file entres in the file table, it'll kill AOM!

If part two of this feature request isn't filled I'm certain I can make a hack in AOM for it.~
Rar
AniDB Staff
Posts: 1471
Joined: Fri Mar 12, 2004 2:41 pm
Location: UK
Contact:

Post by Rar »

As I see it, the problem here is similar to that with shadow files - a current 'file' needs to be split into several different parts.

For example:
Episode 1 / Episode 2 - Running Time
|
File Group Info - File Size, Group, Source, Langs, Quality, Codecs
|
Specific File A / B - ed2k Hash, Crcs, Corruption

Grr... Shadow files still making my head hurt.

Rar
wahaha
AniDB Staff
Posts: 1497
Joined: Sun Nov 17, 2002 3:33 pm

Post by wahaha »

PetriW wrote:
wahaha wrote:I second the 2nd post ^^, but IMO it'd be nice to even have the full set of hashes for the corrupted file and also have this hash associated with the file (globally, instead of only the single mylist-entry).
Problem with this is you get soooo many more file entres in the file table, it'll kill AOM!
OTOH, if these ed2k-links were associated with one's mylist alone, they couldn't be identified anymore by anyone but the one person who added it.
Since there are widespread files with a corruption, this would create two different kinds of entries for corrupted files: Those with their own entry and those with only a private entry in one's mylist.

I really think adding such possibly corrupted files in private would defeat the concept of seperating the filelist and the individual mylists.
exp
Site Admin
Posts: 2438
Joined: Tue Oct 01, 2002 9:42 pm
Location: Nowhere

Post by exp »

well,

my current stand on this one is:

a) wide spread corrupted files should be added to anidb as normal file entries with the crc-invalid flag set. all the ideas here apply only to files with individual corruption (aka (almost) no one else has a file with the same hash).
that's why we have the deprecated files hiding feature after all.

b) i will probably auto-add one "special" file per ep someday. That one would have no size, no group and would be shown differently. It would be possible to add it to mylist like any other file though.
this file would mainly be usefull to those who have an ep on dvd or watched it on tv bc they no longer have to add some random file for each ep to their mylist.
that could then also be used by ppl who have a corrupted version of a file.
they would of course "loose" the group info by doing that but they could also add the uncorrupted file to mylist and set the state to deleted.

c) about the 2nd request, as stated in a) if multiple ppl have the same corrupted file it should have it's own file entry so as i see it atm this one is pretty useless.

BYe!
EXP
yidaki

Post by yidaki »

exp wrote: a) wide spread corrupted files should be added to anidb as normal file entries with the crc-invalid flag set. all the ideas here apply only to files with individual corruption (aka (almost) no one else has a file with the same hash).
that's why we have the deprecated files hiding feature after all.
It doesnt have to have an invalid CRC just because its corrupted.
They could have released it as a corrupted file, and just ignored making a V2.
exp
Site Admin
Posts: 2438
Joined: Tue Oct 01, 2002 9:42 pm
Location: Nowhere

Post by exp »

yidaki wrote:
exp wrote: a) wide spread corrupted files should be added to anidb as normal file entries with the crc-invalid flag set. all the ideas here apply only to files with individual corruption (aka (almost) no one else has a file with the same hash).
that's why we have the deprecated files hiding feature after all.
It doesnt have to have an invalid CRC just because its corrupted.
They could have released it as a corrupted file, and just ignored making a V2.
well i am talking about files corrupted @ download or storage here.
if the group released a defective file that one could of course still be crc-verified @ anidb.

BYe!
EXP
PetriW
AniDB Staff
Posts: 1522
Joined: Sat May 24, 2003 2:34 pm

Post by PetriW »

You're kinda missing the point i think. This is only so people who have a corrupted copy that is NOT shared can add it to their mylist without being counted in the user stats.
exp
Site Admin
Posts: 2438
Joined: Tue Oct 01, 2002 9:42 pm
Location: Nowhere

Post by exp »

PetriW wrote:You're kinda missing the point i think. This is only so people who have a corrupted copy that is NOT shared can add it to their mylist without being counted in the user stats.
i am perfectly aware of that.
and i think the part b) would be suitable for those ppl.

BYe!
EXP
kidan
Posts: 319
Joined: Thu Feb 13, 2003 9:13 pm
Location: .DE

Post by kidan »

Woudn't it be an idea to buffer new ed2k-hashes for about a week and count how often those are submitted by different users.

Design:
1. The file's details should be saved in a duplicate of the original file-table.
(not too much work on the DB)

2. There should be a cross-table recording which users submitet the new hash. (2 Cols: tempFID, UserID)

3. Trigger: daily(?)
If a file reaches a defined threshold, it would become a regular file by moving its entry in the original file-table, otherwise it would be discarded after 7 days. It might be a nice feature to autoadd this file to the submitting user's mylists.


While a file is 'on hold' people should be able to find it via search and it would be nice, if there was a list of all 'on hold' files linked (count possibly included in the link) somewhere on the anime-detail-page.

That way AOM would be able to auto-add unknown files to the DB and only the good ones would be added permanently.

For people with individually corrupted files and DVD/TV-seen the pseudo-file-entry would be an good addition to this sceme.
wahaha
AniDB Staff
Posts: 1497
Joined: Sun Nov 17, 2002 3:33 pm

Post by wahaha »

Isn't that basically an extension of deprecated files? Adding them as normal and hiding (in your suggestion: deleting) them after a certain time?
kidan wrote:That way AOM would be able to auto-add unknown files
Well... how (to know which anime/ep/group/other settings to use)? ;)
Locked