[CHII] changed cmds: !addfile and !remove [DONE]

[wahaha]

Just ran over the "feature" mentioned in [Chii] ed2k adding bug [Feature|ON TODO] too ^^

Code: Select all

<wahaha> !addfile ed2k://|file|[a-e]_Tenshi_na_Konamaiki_20.avi|183609344|a7b611a0211b6bd310c9958bdb265c60|
<Chii[AR]> ADDFILE: Tenchi Universe - 8 - No Need For A Guiness, by AnimeSource (gid: 153), 183.609.344 bytes (fid: 6415). FILE STATUS: ADDED TO MYLIST AS UNWATCHED

Hey, at least (incidentally) "Tenchi" was in it too ^^

Now, there is both that "loose" adding, while there's also the double-checked !addfile <Anime/aID> <EpNum> <fID> [w] ...

!addfile
Current command:
"!addfile <exact anime name/aID/stitle> <epno> <fID> [w]"
or "!addfile <ed2k-link> [w]"
or "!addfile last [w]"
Current output:
In the first case, it adds the file "fID" to the mylist if it matches the values of anime-name/aid/stitle and ep-number.
In the second case, it adds either the exact md4/size-match to the mylist, or the file with the exact size (if there is only one file in the db with the same size), or it shows a list of files with a size-match.
In the third case, it adds the last file shown by the user with the "!file"-command.
Adding "w" at the end marks the file "watched".
Command suggestion:
Replace the first one by two commands:
"!addfile <exact anime name/aID/stitle> <epno> [<group-tag/gID>] [w]"
and
"!addfile <fID> [w]"
Output suggestion:
The first command would add the episode to the mylist, either the only one in the db (for that ep) or the one according to the group-specification. If there are multiple files (for the same ep or group) it should show a list of them.
The second command would add the file directly by file-ID.
Reasons:
Consistency... as stated above, it doesn't fit that there's the strict double-checked-adding via fID while there's also the loose adding by size.
The first possible replacement might also be "upgraded" to an epno=all-parameter, given that was a "wanted" feature. It also looks more intuitive to me - but that does not really count ^^
The second command is way faster than "!file x -- !addfile last" or typing the full "!addfile <aID/...> <epno> <fID>"-line
Drawbacks:
Of course, since there's no "!removefile"-command, it should be prevented that people accidentially add the "wrong" file to their mylist. After all, this is a general concern when not using the ed2k-hash for identifying a file. Maybe there's a need for such a remove-command with mainly the same parameters as "!addfile".


As always, this is meant to be a discussion-base - I just felt like suggesting a more precise way of changing the command to prevent obstacles before it's implemented, or maybe figure out that it's should be changed in another way, or not at all.

[wahaha]

I forgot...:
I already remarked that using the words "addfile" might be confused with a function to "Add a new file to the DB" instead of its real function to "Add a known file to the Mylist"

Any (re)naming-suggestions?
Exp already mentioned "!addtomylist"... would that do the trick or is renaming not neccessary after all?

[exp]

partially done.
!addfile does now ask the user on a size match if he really wants to add that file.

@groupname
in !addfile, this might be userfull, but is quite some work, on TODO.

@!addfile <fid>
well i guess after i implement a !remove command this might be a good idea to (simpler). on TODO.

BYe!
EXP

[wahaha]

Another one:
It'd be nice if an !addfile [...] w would mark the file watched even if it already is in the !mylist.
Currently, the !addfile-request is rejected (stating "already in mylist").

[exp]

hm, k.

so you will still get an error already in mylist but it would never the less mark that file watched.
on TODO

BYe!
EXP