Allow to merge placeholder files with generic files [DONE]

old granted and denied feature requests

Moderator: AniDB

Locked
wahaha
AniDB Staff
Posts: 1497
Joined: Sun Nov 17, 2002 3:33 pm

Allow to merge placeholder files with generic files [DONE]

Post by wahaha » Fri Sep 03, 2004 2:01 pm

Actually, everything needed for this is already in, but there are two problems:
- The only way to access the merge-function is by using this random feature
- Only files with the same size can be merged, so there would need to be an exception if the master file is 0 bytes

EDIT: As it seems, that size-check can be overridden aswell by forging the values of the dropdown. So, merging a placeholder and a generic file is already possible, but... ^^;

pelican
AniDB Staff
Posts: 234
Joined: Wed Aug 11, 2004 11:19 pm

Re: Allow to merge placeholder files with generic files

Post by pelican » Fri Sep 03, 2004 2:45 pm

Placeholders still have their place until shadow files are implemented, because of the group field.

wahaha
AniDB Staff
Posts: 1497
Joined: Sun Nov 17, 2002 3:33 pm

Post by wahaha » Fri Sep 03, 2004 2:50 pm

I know that this is a small loss of information - but in the end, you'd only have an additional generic file in your list. And that one could even be filtered out with some simple rules.

pelican
AniDB Staff
Posts: 234
Joined: Wed Aug 11, 2004 11:19 pm

Post by pelican » Fri Sep 03, 2004 4:24 pm

wahaha wrote:I know that this is a small loss of information - but in the end, you'd only have an additional generic file in your list. And that one could even be filtered out with some simple rules.
If we could change the placeholders to, um, `specific generic files', I guess, which have groups but no sizes or checksums, that would be okay, as I didn't just see the second of two episodes aired back-to-back `somewhere'. I saw something by a specific group and want my list to reflect this.

egg
Posts: 769
Joined: Tue Nov 11, 2003 7:17 am

Re: Allow to merge placeholder files with generic files

Post by egg » Fri Sep 03, 2004 10:15 pm

pelican wrote:Placeholders still have their place until shadow files are implemented, because of the group field.
Technically no they don't. Since they are placeholders, there was no release for [just] that episode by that subber. As long as you know all of your files come from [XXX] then why does it matter if there is no group name on a non-existant file that is just there so that mylist will say the anime is complete. It is because of a lack of a feature in AniDB that it is necessary in the first place, when shadow files are implemented then they will not be necessary for this use...

User avatar
exp
Site Admin
Posts: 2438
Joined: Tue Oct 01, 2002 9:42 pm
Location: Nowhere

Post by exp » Fri Sep 03, 2004 11:25 pm

well,

generic files were clearly meant to replace all current placeholder files.
i will add easier methods for mods to merge placeholder files into generic files once the generic files are fully implemented.

IMHO there is no real loss of information. Users who wish to note the exact group of the file should add it as a comment for the generic file's mylist entry.

BYe!
EXP

Skywalka
Posts: 889
Joined: Tue Sep 16, 2003 7:57 pm

Post by Skywalka » Sat Sep 04, 2004 11:05 am

Funny, my whole way of thought is reproduced in this thread :-)

First I also thought information is lost, then I thought no, I just need generic files to make an Anime complete and then when I added PoT 66 (generic file, "second part" of the double episode 65), I simply added a comment :-)

One thing I would like to request though: I had to choose "other" in the dropdown box when I added the file and I think this is the only thing that could be changed - there should be an option like "WWW Fansub" or "spacefiller (completion)" or whatever. Then I would simply have to add the groupname in the comments field for I think making Anime complete in your mylist is is a major use for generic files.

Guest

Post by Guest » Sat Sep 04, 2004 11:21 am

still so that chii will give wrong info.

Guess it's not eazy to implement shadow files where the group can reflected by chii

E-Viper

User avatar
exp
Site Admin
Posts: 2438
Joined: Tue Oct 01, 2002 9:42 pm
Location: Nowhere

Post by exp » Sun Sep 05, 2004 8:43 am

you mean that chii will then tell you that you have one file by "nogroup" or something like that?
it would be pretty easy to add a generic file detection, so chii wouldn't display a generic file as "nogroup" but as "generic".
this could then be improved further if we include that additional state "filler" which could make chii display the group of the file for the previous ep.

BYe!
EXP

e-Viper
Posts: 79
Joined: Mon Jun 07, 2004 12:38 pm
Location: Belgium

Post by e-Viper » Mon Sep 06, 2004 8:46 am

woule be nice 8)

egg
Posts: 769
Joined: Tue Nov 11, 2003 7:17 am

Post by egg » Fri Feb 04, 2005 9:16 pm

wahaha wrote:Since these filler-files were valid to use at that time, I think they should only be merged with the generic files if the mylist-type can be changed to "filler" at the same time (by the mod who merges them).
This functionality is still needed to be able to merge files to a generic and set the generic type for the users who have that file in a single step.

Locked