[CGI] Ed2k links generated wrong for non-English subs[NOBUG]

[NegiNegi]

I'm adding a bunch of files today with Japanese audio and Spanish subtitles. The ed2k link is generated like this: "...[ML](dub.sub_jap.sp)[AniDB].avi..." -- note "dub.sub" appears although this is not dubbed. I noticed the same thing for an episode with French subtitles.
IMO, it should only show "dub" if there is a non-Japanese audio track present -- that is, if a "dual" audio track has been entered.
Example: http://anidb.ath.cx/perl-bin/animedb.pl ... xpandall=1

[exp]

actually this is exactly the way it's ment to be.
(dub.sub_jap.sp)
states:
audio = jap
subs = sp

key1.key2 value1.value2

i agree that this might be confusing to some ppl, however i couldn't think of a better nameing scheme so far (note it should not be longer than the current one).

BYe!
EXP

[NegiNegi]

Count me as one of those people. I actually think it's fairly cool that the database generates a filename automatically based on the metadata; this ensures consistency on the site, and of course people can still name the files whatever they want after downloading.

My only suggestion would be to remove the "dub" if the original Japanese voice track is the only audio in the file. Technically speaking, it's not a dub if there's no "foreign" audio language. You don't put "dub" in the filename if it's the typical Japanese audio with English subtitles, so it's inconsistent to do it if the subtitles are Spanish or German or whatever.

FYI, my personal file-naming convention is "Anime - Ep# [FanSub][Aud1+Aud2..AudN-Sub1+Sub2..SubN].foo"

[Iceman[grrrr]]

Or instead of dub.sub put aud.sub...

you know, dub really means dubbing... original language isn't really dubbing!

[wahaha]

IceMan[grrrr]: We're talking about anime here, cels don't talk much (neither do files)

My only suggestion would be to remove the "dub" if the original Japanese voice track is the only audio in the file. Technically speaking, it's not a dub if there's no "foreign" audio language.

I second this request.

FYI, my personal file-naming convention is "Anime - Ep# [FanSub][Aud1+Aud2..AudN-Sub1+Sub2..SubN].foo"

So it would look like "[jap+eng-eng]" in case of dual audio.

I personally use "... [aud1&aud2&..., sub1&sub2&... sub]", so it looks like "[jap&eng, eng sub]". It's not as short as it could be, but IMO it's somewhat intuitive.

[NegiNegi]

FYI, my personal file-naming convention is "Anime - Ep# [FanSub][Aud1+Aud2..AudN-Sub1+Sub2..SubN].foo"

So it would look like "[jap+eng-eng]" in case of dual audio.

Exactly -- for a dual-audio, no-subs file. I've been idly thinking about changing to Internet country codes instead, so it would be [Jp+En-En+Es]... but I've got so many already burned with my old style (or no style, from the very beginning) that I think, "Why change again?"

I personally use "... [aud1&aud2&..., sub1&sub2&... sub]", so it looks like "[jap&eng, eng sub]". It's not as short as it could be, but IMO it's somewhat intuitive.

On our own hard drives, we are kings. I have a personal dislike for the ampersand, since it causes silly things to happen if I forget to escape it in a command shell.

[Elberet]

Hmm, removing japanese is a bad idea, I think. After all, there could be cases where even japanese is only a dub and not the original audio...

If someone's really, really picky about naming the files correctly, the language block should include that information. For example: "[jap+dub_eng+sub_eng]" if japanese is the original language, or "[dub_jap_eng+sub_eng]" if it's a dub. In other words, the language block would be made up of the original language, a "+", the word "dub" and a list of dub languages separated by "_", a "+", the word "sub" and a list of subtitle languages separated by "_".

[exp]

Hmm, removing japanese is a bad idea, I think. After all, there could be cases where even japanese is only a dub and not the original audio...

If someone's really, really picky about naming the files correctly, the language block should include that information. For example: "[jap+dub_eng+sub_eng]" if japanese is the original language, or "[dub_jap_eng+sub_eng]" if it's a dub. In other words, the language block would be made up of the original language, a "+", the word "dub" and a list of dub languages separated by "_", a "+", the word "sub" and a list of subtitle languages separated by "_".

however anidb doesn't know about "original" language, it simply lists the language of the audiotrack of a file.
so there isn't any easy way to implement a nameing scheme like the one you proposed.

BYe!
EXP

[wahaha]

On our own hard drives, we are kings.

*looks at a few thousand adjusted filenames*
*nods*

I have a personal dislike for the ampersand, since it causes silly things to happen if I forget to escape it in a command shell.

Hehe, true. One could change it to "... [jap+eng, sub eng]" though ^__^;

[kidan]

Isn't there an option to customize your own ed2k-links on exp's todo list? Seems like this feature would be really appreciated.

[Elberet]

so there isn't any easy way to implement a nameing scheme like the one you proposed.

Indeed. So someone would need to implement an 1:n relation for file -> (language + type) and make a switch that declares one of the languages the original language. That would solve all current problems related to languages.

[Skywalka]

Just my 2 cents:

I'd vote for "dublang1+...+dublang(n-1)+dublangn dub, sublang1+...+sublang(n-1)+sublangn sub"

Which (for a file with english and japanese dub and english and german subtitles would result in:

jap+eng dub, eng+ger sub

That is how I name my files and I guess having the option what to include in ed2k links is a good idea. I acutally don't name my files that way, I only use "Anime Title - EPNumber [group]".

If that switch is already implemented feel free to tell me how to do it